search

libyal / libvmdk

Library and tools to access the VMware Virtual Disk (VMDK) format
GNU Lesser General Public License v3.0
163 stars 66 forks source link

Case-sensitive descriptor section heading parsing is too strict #5

Closed uckelman closed 8 years ago

uckelman commented 8 years ago

I've come across some VMDKs which have # The disk Data Base as a descriptor file section header instead of # The Disk Data Base as specified in the spec. I don't know what's producing these, but as they are otherwise conformant images and the section headers are strictly speaking just comments, it would be nice if libvmdk would read them.

The only required change to libvmdk is to use libcstring_narrow_string_compare_no_case instead oflibcstring_narrow_string_compare` when checking the section headings. Patch to follow.

uckelman commented 8 years ago

Fixed in PR #6.

joachimmetz commented 8 years ago

Any indication in the descriptor file that might hint to the creating tool?

uckelman commented 8 years ago

Any indication in the descriptor file that might hint to the creating tool?

I've been told it was written by VirtualBox.

uckelman commented 8 years ago

Yes, it definitely could have come from VirtualBox. The oddly-cased header is right there in the VirtualBox source: https://www.virtualbox.org/browser/vbox/trunk/src/VBox/Storage/VMDK.cpp#L1994

There could be quite a lot of these in the wild.

joachimmetz commented 8 years ago

Thanks, useful info