licenses / lice

Generate license files for your projects
BSD 3-Clause "New" or "Revised" License
506 stars 38 forks source link

docs updated #24

Closed alex179ohm closed 11 years ago

jcarbaugh commented 11 years ago

Hi. First of all, I LOVE this idea!

A few thoughts on implementation...

Again, this is really amazing and very much appreciated! I'd definitely like to know what you think about the suggestions.

jcarbaugh commented 11 years ago

Also, I'm seeing a total of four pull requests. Does this one have all of the same commits as the others? If so, I'm going to close those and we can just focus on this one.

alex179ohm commented 11 years ago

I think the code that turns a block of text into a com... I agree... A separate function will be more clean and reusable. When I wrote the code I just added some future on the fly (whitout design ). this commit 63868a83e80baeb5b23a51a134baa4110242a744 fix it.

I think the -f argument could accept a filen... Yes is more user friendly, simply to use and it would be very easy to implement. The only reason I missing to include it, it' s because I wrote the code with just my needs in the mind. so this commit 7da943b458d32e3d7e23468c41e090b2f0a49b0a fix it.

Also, I'm seeing a total of four pull requests. Does this one have all of the same commits as the others? If so, I'm going to close those and we can just focus on this one.

I drop you a new pull_request with my master in this issue and you can close all the others. (I'm terrible sorry I open one issue for pull request...so you can focus in this one, it's just a my mistake)

Note, the languages supported whit this new pull request was expanded, check the README file for a complete list.

So I have a new suggestion too. In more languages both multiline and "single" line comment are used to include a license stuff in the source file.

a good example is perl (ruby for example is the same): multilne is:

=item
license stuff
=cut

but a unix style (like python) is common used. So a new argument would be implemented for control short and multiline comment style. What do you think about?

Regards.. Alex