search

lichen-community-systems / Flocking

Flocking - Creative audio synthesis for the Web
GNU General Public License v2.0
697 stars 60 forks source link

Model Synths don't correctly support array-valued inputs specified in their models #135

Closed colinbdclark closed 8 years ago

colinbdclark commented 8 years ago

flock.modelSynth provides an adapter between the world of Infusion component models and Synth inputs. This feature is being used by the FLOE chart authoring sonification tool, which relays a model representing the sonified form of some pie chart data into input parameters to a synth.

However, there is currently a bug in the implementation of flock.modelSynth.flattenModel, which flattens arrays into individual paths unnecessarily. An additional condition should be added to ensure that arrays are not flattened (as is done for primitive types and ugenDefs).

colinbdclark commented 8 years ago

Fixed with tests in 170b4b9a33884b00fe9c9fcb1ecdcf0046dd5697