search

lichen-community-systems / Flocking

Flocking - Creative audio synthesis for the Web
GNU General Public License v2.0
695 stars 60 forks source link

Fixes gh-193: Corrects the order of MSB and LSB when reading 14-bit MIDI values. #194

Closed colinbdclark closed 7 years ago

colinbdclark commented 7 years ago

@the-t-in-rtf, I don't have a controller with a proper pitch bend wheel on it. Can you try this and confirm that this fix works correctly with yours?

the-t-in-rtf commented 7 years ago

@colinbdclark, sure thing. I'll test with both the oxygen8 and nanopad.

the-t-in-rtf commented 7 years ago

Sorry, forgot to close the loop here yesterday. I reconfigured my handling of pitchbend to use the full range of 0 +/- 8192 values, and then tested with the previous code. My newer controller (a Korg nanopad 1) reported the correct range of values with the old code, while my older controller (an M-Audio Oxygen8 v2) reported 0-126, and then a very high value.

When I updated to the code under review here, both controllers correctly report the full range of values.

colinbdclark commented 7 years ago

Thanks for verifying this, @the-t-in-rtf! I've merged the fix into the midi-improvements branch, which should hit master as soon as the unit testing work is complete.