search

lichen-community-systems / Flocking

Flocking - Creative audio synthesis for the Web
GNU General Public License v2.0
693 stars 60 forks source link

added tanh distortion #208

Closed drart closed 6 years ago

colinbdclark commented 7 years ago

Hi @drart, this looks awesome! Thanks for the contribution. Any chance you'd be willing to also create a simple demo and documentation page for this unit generator? I'm happy to merge the pull regardless, and I certainly have created tons of ugens that don't have documentation, but it might be great to have some for the start for this new one. Let me know if you have the cycles for this. Bonus points for a unit test!

drart commented 6 years ago

No bonus points yet, but I have added documentation for all distortion ugens. I included a demo for the tanh distortion and a few others.

colinbdclark commented 6 years ago

@drart This pull request is awesome. I have made some modifications to it in #223, which you can take a look at for reference. Just for housekeeping, I'm closing this PR in favour of #223. Thanks so much for these improvements, they're great!

colinbdclark commented 6 years ago

It's in! Merged at e64720c8d3dd1254f1addec3e86f8af38e8dcba5. Thank you again so much for this, @drart. Your distortion demos sound awesome!