search

lichen-community-systems / Flocking

Flocking - Creative audio synthesis for the Web
GNU General Public License v2.0
693 stars 60 forks source link

Add ability to send (non-raw) MIDI messages. #224

Closed the-t-in-rtf closed 5 years ago

the-t-in-rtf commented 6 years ago

Adds the ability to send (non-raw) messages to a MIDI device, and a demo of same. See the related GitHub issue for details.

the-t-in-rtf commented 6 years ago

Still working on refactoring away the temporary arrays, but wanted to point out a test failure in the web audio tests:

not ok 41 Chrome 67.0 - Composition #1: ./html/webaudio-tests.html

stack: > at runLoggingCallbacks (http://localhost:7357/3019/node_modules/infusion/tests/lib/qunit/js/qunit.js:1609:19) at F.ok (http://localhost:7357/3019/node_modules/infusion/tests/lib/qunit/js/qunit.js:544:3) at Object.flock.test.arrayNotSilent (http://localhost:7357/3019/tests/unit/js/flocking-test-utils.js:350:15) at http://localhost:7357/3019/tests/unit/js/webaudio-tests.js:228:24 at http://localhost:7357/3019/tests/unit/js/webaudio-tests.js:112:17 at wrapper (http://localhost:7357/3019/src/scheduler.js:644:17) at Object.fire (http://localhost:7357/3019/node_modules/infusion/src/framework/core/js/Fluid.js:1568:40) message: > flock.ugen.mediaIn: Reading input samples.: undefined First silent sample found at: -1 Log: | ...

The same error occurs in master, so this is not unique to my work here.

the-t-in-rtf commented 6 years ago

OK, @colinbdclark, I think we'll probably need to discuss refining both flock.midi.write.sysex and flock.midi.read.sysex further, but this should at least be ready for review again.