deadlocks on large stderr's

licheng / gccfilter

gccfilter is a perl filter to colorize and simplify (or expand) gcc diagnostic messages. gccfilter is particularly aimed at g++ (i.e. dealinging with C++) messages which can contain lot of template-related errors or warnings difficult to sort out.

21 stars 6 forks source link

deadlocks on large stderr's #4

Closed spiffomatic64 closed 8 years ago

spiffomatic64 commented 9 years ago

according to http://perldoc.perl.org/IPC/Open3.html this should be using select, and reading with sysread.

I was able to patch this in by building one large temporary buffer, splitting into new lines, and passing to gcc_stderr without too much change

zed0 commented 8 years ago

This is apparently fixed in @dichlofos 's fork. Might be nice to have that pulled in.

dichlofos commented 8 years ago

Wait a moment, I'll try to submit PR today :)

dichlofos commented 8 years ago

Here it is: https://github.com/licheng/gccfilter/pull/9 I've tested main functionality (coloring) and checked that coloring disable on redirection works, but as no unit tests supplied, I could suddenly broke smth else :)

dichlofos commented 8 years ago

Okay, this issue can be closed now?