lichengdong / timthumb

Automatically exported from code.google.com/p/timthumb
1 stars 0 forks source link

No error returned when external url NOT in allowed list #259

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
Have an image src url that is hosted on a server NOT in the $ALLOWED_SITES array

What is the expected output? What do you see instead?

I would expect either it gives an error much like the image is not found or the 
default image is shown as if no image found in post

What version of the product are you using? On what operating system?
I am using script version 2.8 and wordpress 3.2.1

Please provide any additional information below.

Example link 
http://www.dougberger.net/archive/2008/10/john-mccains-palling-around-with-charl
es-keating-who-defrauded-tax-payers-in-late-1980s.html

Original issue reported on code.google.com by voncadf...@gmail.com on 7 Sep 2011 at 4:49

Attachments:

GoogleCodeExporter commented 9 years ago
If you right click the image and open in new tab you will see it shows you an 
error. I think this is a good enough error report for you to debug the problem.

Original comment by BinaryMoon on 7 Sep 2011 at 10:06

GoogleCodeExporter commented 9 years ago
Thanks. I would never have thought to view image to see the error message.

I do seem to have another issue. When I filled in the error image to use then I 
get this error instead:

It says "The image 
'http://www.dougberger.net/wp-content/themes/dougTooldv/scripts/timthumb.php?src
=http://punditkitchen.wordpress.com/files/2008/09/political-pictures-barack-obam
a-chill-out-got-this.jpg&w=100&h=100' cannot be displayed because it contains 
errors"

I have this set:
if(! defined('ERROR_IMAGE') ) define ('ERROR_IMAGE', 
'http://www.dougberger.net/wp-content/uploads/2011/08/dougsviews.jpg');

but it still gives me the error noted here.

Original comment by voncadf...@gmail.com on 8 Sep 2011 at 5:27