lichess-bot-devs / lichess-bot

A bridge between Lichess bots and chess engines
GNU Affero General Public License v3.0
715 stars 434 forks source link

Allow all commands that start with `!eval` to overcome spam rules #967

Closed eduherminio closed 1 month ago

eduherminio commented 1 month ago

Type of pull request:

Description:

Context

When watching bot games, chat spam become very strict when trying to send the same command multiple times, which usually happens for !eval command. This seems to be the piece of code responsible of detecting a message as spam. It basically detects duplicated messages (thanks @tsoj!)

There was an attempt to improve this on lichess side Relaxing spam rules for when being a normal user alone with just BOT accounts in chat, but it didn't make it.

Proposal

We can improve spectator experience on our side by allowing multiple commands to return our bot's eval. The easiest way I could think of is doing so for every command that starts with (!eval), i.e. !eval1234, !evalplease, !eval with spaces.

This change has been applied to my bot and can be verified right now by watching any of his games and entering those commands one after each other.

Related Issues:

Checklist:

Screenshots/logs (if applicable):

image

eduherminio commented 1 month ago

If this moves forward, happy to update any related documentation before or after merging.