search

lichess-bot-devs / lichess-bot

A bridge between Lichess bots and chess engines
GNU Affero General Public License v3.0
715 stars 434 forks source link

Update README #981

Closed AttackingOrDefending closed 1 week ago

AttackingOrDefending commented 2 weeks ago

Type of pull request:

Description:

The structure was based on stockfish.

I can also create a new project (e.g. called lichess-bot-images) and upload the icon there, so the link would be more readable (would change from https://repository-images.githubusercontent.com/129721834/49e3e215-c2bc-4116-a5da-f7ed44b3cb9b to https://github.com/lichess-bot-devs/lichess-bot-images/icon.png). Right now, I am using the link for the social preview image.

Related Issues:

None.

Checklist:

Screenshots/logs (if applicable):

AttackingOrDefending commented 2 weeks ago

@MarkZH Do you think it having the image in a different project will be better?

MarkZH commented 2 weeks ago

Looks good. I would reduce the bottom margin of the image so there isn't so much space between the knight and the title. I think the image location is fine where it is. I don't think we'll be modifying it very often.

AttackingOrDefending commented 2 weeks ago

I can't find a way to crop the image using html in the markdown file and I don't want to change the social preview image, because GitHub suggests that social preview images have a margin of at least 40px so that they are displayed corrcectly.

The simplest solution seems to be cropping it locally and uploading it in a different repo.

MarkZH commented 1 week ago

Creating an new repository for images is probably best. The current URL has a decent change of breaking if GitHub ever changes its backend.