Update eraseOnClick logic

[rcpooley]

Old Logic

Assuming white to move

eraseOnClick=true

• Clicking anywhere will clear shapes

  eraseOnClick=false

• Clicking on white piece will not clear shapes
• Clicking on black/no piece will clear shapes (bug)

  New Logic

  eraseOnClick=true

• Clicking anywhere will clear shapes

  eraseOnClick=false

• Clicking anywhere will not clear shapes

[ornicar]

There must exist a reason why these conditions were added in the first place. What will removing them break?

[niklasf]

Since the default is true, the only place that is affected in lila is studies:

ui/analyse/src/ground.ts:      eraseOnClick: !ctrl.opts.study || !!ctrl.opts.practice,

There, clicking an empty square would no longer clear the drawings, exactly as you analyzed. However that's the behavior we want.

So it's really the name of this option that's misleading. It could have been called eraseOnAnyClick or eraseEvenOnMovablePieceClick.