search

lichess-org / dartchess

Dart chess library for native platforms
https://pub.dev/packages/dartchess
GNU General Public License v3.0
33 stars 17 forks source link

Add Horde Variant #12

Closed nav-28 closed 1 year ago

nav-28 commented 1 year ago

resolves #6

lenguyenthanh commented 1 year ago

Great job @nav-28, I'll have time to review this carefully in the weekend.

lenguyenthanh commented 1 year ago

In scalachess, we have few more checks for insufficient material: https://github.com/lichess-org/scalachess/blob/master/src/main/scala/variant/Horde.scala.

should we also implement it here for consistency between client & server?

nav-28 commented 1 year ago

In scalachess, we have few more checks for insufficient material: https://github.com/lichess-org/scalachess/blob/master/src/main/scala/variant/Horde.scala.

should we also implement it here for consistency between client & server?

I think the algorithm has sufficient material from Shakmaty covers all the cases. If there is a need, I can add the other checks as well.

veloce commented 1 year ago

This is good to me! Thanks for the great work @nav-28 :)