lichess-org / dartchess

Dart chess library for native platforms
https://pub.dev/packages/dartchess
GNU General Public License v3.0
35 stars 18 forks source link

Improve PGN parser #30

Closed veloce closed 3 weeks ago

veloce commented 1 year ago

Currently 2 tests are not passing:

Currently 1 test is not passing:

https://github.com/lichess-org/dartchess/blob/main/test/pgn_test.dart#L317

Anupya commented 1 year ago

What do you mean by passing because it seems like they are? (I'm on main)

Screenshot 2023-10-25 at 4 41 52 PM

Edit - Just realized you meant the two commented out tests: from smartChess and game from crafty. Line 317 was not pointing at those which is why I got confused 😅

veloce commented 12 months ago

Sorry for late reply, I have too much notifications and I missed yours... Thanks for your interest in this project!