search

lichess-org / lichobile

lichess.org mobile application
https://lichess.org/mobile
GNU General Public License v3.0
2.04k stars 318 forks source link

Remove Firebase Analytics #1121

Closed IzzySoft closed 2 years ago

IzzySoft commented 4 years ago

corresponding to #590 – your switch to FCM accidentally dragged that in. AFAIK it's a simple toggle with the wrong default, incidentally done that way by Google.

gilbsgilbs commented 2 years ago

F-Droid inclusion PR: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11707 .

IzzySoft commented 2 years ago

Congrats to the listing at F-Droid.org! I guess it would be OK now to remove Lichess from my repo to avoid confusion – or would you prefer it to stay? A request for removal was opened on my repo, but as it does not come from here I felt the decision should be delegated to you :wink:

Some background here – and yes, Shuvashish is correct with pointing out Lichess is slightly over the disk space limit alotted to each app in my repo…

IzzySoft commented 2 years ago

@veloce @gilbsgilbs Did you decide? I have no problems with waiting, but having received no reply at all could mean you've missed the note. As the default is removing an app about 10..14 days after it reached F-Droid, I'll now just add a due-date on the request to remove it unless you object :wink: Hope that's OK with you.

veloce commented 2 years ago

@IzzySoft sorry I did not remember you had already the free app on your repo. I'm fine with the removal yes. Actually, seeing your 1st message, I'd let you decide what you want to do as it's your repo. That being said I guess it's better to remove it since now the app is on F-Droid.

IzzySoft commented 2 years ago

@veloce Thanks! Will do then (should you need it back, just give me a ping – it's easily re-established). I was just unsure as the package names differ. Could have been due to different functionality.