lichess-org / lichobile

lichess.org mobile application
https://lichess.org/mobile
GNU General Public License v3.0
2.03k stars 318 forks source link

Unable to accept correspondence challenge #961

Open mmodenesi opened 5 years ago

mmodenesi commented 5 years ago

I'm submitting a ...

Bug report

Current behavior:

An opponent sends a rematch offer from a finished correspondence game. User sees a notification icon with two kind of swords in a red color.

There is no way to accept nor decline the offer on the mobile app. Expected behavior:

User can accept or decline the offer.

Steps to reproduce:

Obvious Environment information

freefal commented 5 years ago

I just tried to reproduce this. When I click the red swords, I'm brought to a screen where I can accept the rematch offer. What happens when you click the red swords?

mmodenesi commented 5 years ago

When I click the red swords, I see a board with the message "user xyz is inviting you to a match (standard, one day)", or something similar, I am quoting by heart. But there is no "accept" or "decline", tapping the message doesn't produce any result, either. All I can do is swap it to the side and see other ongoing matches. I'll take a screenshot next time. Thanks for your time.

freefal commented 5 years ago

Interesting. Just below that message there should be accept/decline buttons. Can you send a screenshot of what you're seeing?

On Thu, Mar 21, 2019, 4:03 AM mmodenesi notifications@github.com wrote:

When I click the red swords, I see a board with the message "user xyz is inviting you to a matc (standard, one day)", or something similar, I am quoting by heart. But there is no "accept" ot "decline", taping the message doesn't produce any result, either. All I can do is swap it to the side and see other ongoing matches. I'll take a screenshot next time. Thanks for your time.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/veloce/lichobile/issues/961#issuecomment-475187607, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6RdqTfMwCmO0UazyZ7gUk0WrJsDwmPks5vY2bkgaJpZM4byzF_ .

mmodenesi commented 5 years ago

After finishing a game,

my opponent offers a rematch. I see the swords and a badge with a (1)

photo_2019-03-23_19-57-59

If I tap on the swords I see this,

but there's nothing I can do to accept or decline.

photo_2019-03-23_19-58-10

If I open main menu,

go to "Correspondence" and open tab "challenges", I still can't accept or decline

photo_2019-03-23_19-57-50

freefal commented 5 years ago

Thanks for the screenshots. What kind of phone do you have? I can recreate this, but only by making the screen small in my test environment.

veloce commented 5 years ago

Perhaps a problem of media query here. Knowing the screen ratio and phone model would help.

mmodenesi commented 5 years ago

https://www.gsmarena.com/lg_f60-6709.php

freefal commented 5 years ago

That's so weird. GSM Arena says your phone has 480 x 800 pixels. Punching those dimensions into my test environment results in the challenge looking like this:

Screenshot from 2019-03-26 23-01-23

Even if we hypothesize that the buttons on the bottom are taking up 100px and reduce the dimensions to 480x700, it still looks fine (with room to spare).

Are you using some accessibility mode that zooms in the screen? Thanks for your patience and the good descriptions of the problems you're having. I have to really reduce the number of vertical pixels before I can reproduce the issue of the buttons being cut off.

mmodenesi commented 5 years ago

I am not using any special accesibility mode. The screen is not zoomed in.

2 observations:

1) The image you pasted doesn't look 1:2 to me (400x800, or 500x1000, or whatever). Maybe the simulator is not being so accurate?

2) We can assume my phone is 400x800. The total width of the screen is being used by the application. That is not true for the height. As you said, the buttons from the bottom (and the info bar at the top) are taking some pixels out. Doing an inspection of the image itself, I can see that lichess is taking only 87% of the height of the screen. That would leave us with ~697 pixels