search

lichess-org / lila-docker

Lichess local development using Docker Compose.
GNU Affero General Public License v3.0
44 stars 44 forks source link

Add .pnpm-store volume to docker-compose.yml to get benefits of pnpm #78

Closed Carbrex closed 6 months ago

Carbrex commented 6 months ago

Addind pnpm-store to volumes doesn't download the dependencies again and again on running ./lila-docker ui and other command which include pnpm install. Before: image Downloaded packages every time on pnpm install As far as I understand this is because docker compose run --rm ui /lila/ui/build --update --clean-build --debug $@ makes a new container every time it is run. After: image Just takes the package from pnpm-store directory and doesn't download them again.

Carbrex commented 6 months ago

Also one more thing running ../../lila-docker db from other directory say /repos/lila gives error as settings.env not found. Not sure why the cd "$(dirname "$0")" was removed from lila-docker script.

fitztrev commented 6 months ago

Not sure why the cd "$(dirname "$0")" was removed from lila-docker script.

Unintentional when I changed it to work with multiple-word commands in https://github.com/lichess-org/lila-docker/pull/61

fitztrev commented 6 months ago

Thanks. Wonder why .pnpm-store is already in gitignore.