lichess-org / lila-docker

Lichess local development using Docker Compose.
GNU Affero General Public License v3.0
44 stars 44 forks source link

Add services after setup has already been completed #95

Closed Carbrex closed 4 months ago

Carbrex commented 4 months ago

Closes #47 New services can now be added without ./lila-docker down. Do ./lila-docker add-services to add new services, then select the new services you want to add. Only the new ones among the selected services will be added.

Try on gitpod: https://gitpod.io/new/#https://github.com/Carbrex/lila-docker/tree/add-services-after-setup

Carbrex commented 4 months ago

These 2 tests

test tests::test_gitpod_lila_url ... FAILED
test tests::test_gitpod_lila_url_with_pr_context ... FAILED

sometimes fail randomly and sometimes pass when I run cargo test locally.

Carbrex commented 4 months ago

Nvm, they fail as they run concurrently, cargo test -- --test-threads=1 works fine.

fitztrev commented 4 months ago

Just tried it, looks great! Will test more later.

I wonder if it should still prompt for database setup. If search for instance is added, may need to re-run the seeder to populate elasticsearch.