Open infinitless opened 2 years ago
schlawg
commented
2 years ago It's a little more complicated than that unless you want inviting a team to give everyone contribute or make everyone a spectator. Maybe that would work in v1 but my crystal ball sees folks clamoring for write control on individual team members before long. Regardless, good idea.
infinitless
commented
2 years ago Great, thanks! Maybe the default for "Invite Team" is always spectator. Then it's up to the owner to give contribution rights individually. Most people would be happy with spectating rights :)
schlawg
commented
2 years ago That works. I guess team access could be specified as contribute or spectate just like an individual, and if an individual member from the team is added it would override the default team access for that member only. So you could easily either grant write to all but restrict someone you don't really trust OR make it a spectator study with only a few dudes who can contribute.
A complicating scenario is if someone wants to add multiple teams, one with read, the other with write access and an included member belongs to both. Can you think of a scenario where defaulting to the most permissive (write) access for them would bite anyone?
infinitless
commented
2 years ago Hmmm, not unless both teams are House Montague and House Capulet! Haha. Jokes aside:
Let's say a someone is on two Teams - A and B. Now I create a study and invite both Teams to the Study - both are added as "spectators". Now I give access to this person as a "contributor".
If a notification goes out to the Team members about this change - other team members can use the forum or message the owner if they have objections.
As such, I don't think anyone would have a problem (since the said member is a trusted participant in both the Teams anyway). Can't think of a scenario ¯_(ツ)_/¯
schlawg
commented
2 years ago From TBest on discord:
It's a feature i have seen requested many times, by teams and also by teachers/coaches (whom ofc, can make a team) Random flyby mention, but maybe entry code (like the password for arena's) is wanted by users as well.
- https://github.com/lichess-org/lila/issues/6663 for lichess class, this is a wanted middle step for something like this
infinitless
commented
2 years ago From TBest on discord:
It's a feature i have seen requested many times, by teams and also by teachers/coaches (whom ofc, can make a team) Random flyby mention, but maybe entry code (like the password for arena's) is wanted by users as well.
- Allow Teachers to add Students to Teams #6663 for lichess class, this is a wanted middle step for something like this
Hmm, I think #6663 is much more complicated than #11655. In fact once #11655 is implemented, it could be upgraded to #6663.
The reason #11655 is simpler is that the members are already part of a trusted Team. Therefore all that needs to be done is to shift their access to a study. Maybe I'm wrong. ¯_(ツ)_/¯
schlawg
commented
2 years ago I added the comment to tie the issues so if/when 11655 is done one will also see 6663.
It would be really nice to have a feature called "Team Studies" on LiChess - such that members of a Team can automatically access the Study privately. It is otherwise a nightmare to maintain access for a particular study when you just want members of a particular team to see it. Twice the work.
So where it says "Invite Members" it could also say "Invite Team". The slight complexity would be that people who join the team have access automatically and those who leave, lose access. Then, those who rejoin gain access again.
I think it would be a really really cool feature! Thanks!