lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.55k stars 2.27k forks source link

chess 960 draws are not classified #11669

Open ghost opened 2 years ago

ghost commented 2 years ago

Chess 960 draws seem to not be classified like in standard games for some reason (i.e. threefold repetition, stalemate, etc.) On the game page, it just says “Draw”.

benediktwerner commented 2 years ago

Seems like lila or scalachess doesn't categorize those two properly. It works for the other reasons which are computed based on other data but e.g. the stalemate should have game end reason "stalemate" but does have "draw". And for 3-fold, history.threefoldRepetition apparently returns false: https://github.com/lichess-org/lila/blob/master/modules/game/src/main/Game.scala/#L622 🤔

1rodriguez commented 1 year ago

I think the example cited as stalemate (https://lichess.org/71iab27S), is actually an example of threefold repetition.

Edit: Stalemate looks to be ok unless you can find a counterexample (https://lichess.org/ruAE48lA/black#64)