lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.09k stars 2.23k forks source link

Matchmaking in tournaments considers players who are now offline. This stops for example 2 players who are online (out of 3) from getting more games #11682

Open codegency opened 1 year ago

codegency commented 1 year ago

Exact URL where the bug happened

Steps to reproduce the bug 3 player tournament and one goes off line.

What did you expect to happen? Remaining 2 players keep gettting matched

What happened instead? No more matches

Operating system and browser version

ddugovic commented 1 year ago

On a Lichess-like server, it is argued that "no rematch" behavior is undesirable:

It is now possible to rematch two players when there are only two active players in a tournament. Previously, there was a clause that prevented a player from being paired against their last opponent, but we have removed this restriction when there are just two players in an arena. This means if there are just two human players in a tournament they will be able to play consecutive matches against each other. If there is just one human player then they will play our bot consecutively. Less waiting around! https://playstrategy.org/blog/YzSJKhIAAFRRGJ8y/bots-are-joining-tournaments

codegency commented 1 year ago

The problem here appears to be that a player is deemed active even if he is not online. If active players only considered players online then 2 online players would still get matched when the remaining third player is offline