lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.59k stars 2.28k forks source link

Feature Request: Toggleable x-axis between date and game number for rating graphs #12656

Open rogersheu opened 1 year ago

rogersheu commented 1 year ago

Though I enjoy playing, I take breaks from chess (and thus from lichess) with some regularity. As a result, my rating has some extended periods of time with no movement (see image).

zn65muo

Below is my artist's rendition of what it could look like if toggleable. Just imagine if it were stretched out to the same aspect ratio as the chronological one.

image

I'm wondering if implementing the following makes sense and is possible. I'm not super familiar with TypeScript myself, but I think it'd be a change in ratingHistory.ts here

I think this could be good for the subset of users who want to see their improvement over time, especially for those who do not consistently play. Excuse me in advance if it is already implemented somewhere on the site. (Please let me know where I can find it if it exists!)

EnriqueBet commented 1 year ago

If this is still open, I would like to work on this issue

rogersheu commented 1 year ago

@EnriqueBet Go right on ahead! As far as I'm aware, no one's working on it yet and it hasn't been closed either.

EnriqueBet commented 1 year ago

sounds good! If this doesn't need grooming, can I get assigned to this issue @kraktus or @ornicar? Just confirming with you before starting :)

kraktus commented 1 year ago

We only store the rating number per day, not per game so I don't think we can reasonably implement this. The best we could do would be to have a toggle to remove the days where the user has not played but that's not really useful or what's asked

oakkitten commented 3 months ago

I seem to be able to see my rating for each game. So I am assuming it is possible to expose this data to the graphs in some way. Would love to see this feature implemented for the exact reason OP mentions.

(Just a note; assumingly as a side effect of the current implementation, my “highest rating” is nowhere to be found on the graph, in fact, on the date it's supposed to be the highest it's some 100 points lower what the graph shows. This discrepancy might confusing to the users.)