lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.65k stars 2.28k forks source link

Inconsistencies in crazyhouse pawn drop notation #12661

Open cFlour opened 1 year ago

cFlour commented 1 year ago

Exact URL of where the bug happened

Don't remember, but any analysis board of a crazyhouse game which has computer analysis requested can work. The only thing needing to be there is for a player to play a blunder in-game when the best move is actually a pawn drop somewhere.

Steps to reproduce the bug

Conditions above.

What did you expect to happen?

Lichess to be follow only one type of notation for crazyhouse drops.

What happened instead?

Lichess follows two different types of notation systems for crazyhouse, because the moves show as @c3 and etc, but after requesting an analysis, the analysis comments use P@c3 for pawn drops.

Operating system

UBUNTU 22.10

Browser and version (or alternate access method)

Opera 97.0.4719.63

Additional information

Screenshot: image

lenguyenthanh commented 1 year ago

I guess this one causes by the difference between our chess libraries?

niklasf commented 1 year ago

Also worth noting that P@c3 is UCI notation as sent by fishnet, whereas omitting P is SAN, as intended for user interfaces.