lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.57k stars 2.27k forks source link

Correspondence analysis board move time is capped at 60 seconds #12943

Open stillmtndewfan opened 1 year ago

stillmtndewfan commented 1 year ago

Exact URL of where the bug happened

https://lichess.org/q8plfjpF/ https://lichess.org/UYQxnZ4D/

Steps to reproduce the bug

  1. Go to analysis board of correspondence game
  2. Select move times
  3. Moves that I know were looked at for more than 60 seconds are showing as moved in 60 seconds image image

What did you expect to happen?

I expected to see move time in days:hours:minutes:seconds format or the equivalent in total second.

What happened instead?

Move time for each move longer than 60 seconds displayed as 60 seconds

Operating system

Windows 10

Browser and version (or alternate access method)

Chrome version 113.0.5672.129

Additional information

No response

Dboingue commented 1 year ago

being like that for a long time. Maybe assuming that in correspondance it is difficult to assign time spent on move by mere time between move sent. Although it would be an upper bound already. which would be nice to look at postgame.

But there is the additional question, of adjusting the concept of thinking time to actual tab user activity, if that can be monitored with users consent for example. How long did one spent actually staring or creating user variations. I do not know of the available technologies. It does not stop me from imagining possible such improvement.

However, a realistic upperbound related to the correspondance time bracket would be fixing this already.

csaavedra commented 1 year ago

The upper bound for that graph should just simply be the move limit time for the game (that is, 24h or 48h in typical correspondence games, etc). It shouldn't be difficult to do and it would be very helpful later when analyzing the game, to see how long one took in critical moves.