lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.63k stars 2.28k forks source link

Game analysis movelist: better display the end of the game when adding additional moves #13873

Open drbeco opened 1 year ago

drbeco commented 1 year ago

Please make the last message with the results to be always near the last actually played moves.

Currently, when you analyze new moves, the only difference between the actual moves and the fictitious moves is a ITALIC font. That is not good enough to differentiate where the game ends.

I hope the image will show it better than words.

Thanks!

lichesslastmessage

Forum post for reference: https://lichess.org/forum/lichess-feedback/make-last-message-to-be-always-after-the-last-move

Siderite commented 1 year ago

Sounds nice as a feature app, but there's a snag with the game notation. It would have to be a Lichess specific comment escape string, or at least some comment pattern to demarcate the last move. This also affects the PGN imports and exports, the merging of PGNs with different terminations, etc.

For example I tried importing this:

[Result "1-0"]
1. e4 1-0 1...d5

the result was:

1. e4 { 1-0 White wins. } 1-0

As you can see 1-0 is considered the termination of the game as well as the one of the PGN (as per PGN standard). Take into consideration the (stunted) Analysis window which ignores comments and you get a pretty inconsistent behavior.

Perhaps the (non-standard) annotation glyph Ending (⊥) could work, in conjunction with a Result tag and/or the automated { 1-0 White wins } like comment.

drbeco commented 1 year ago

Maybe we keep the last message where it is, and not change the PGN at all.

Instead, include a second comment as result just after the real moves.

There is no harm in having two {"black resigned"} messages, one the same place where it's always been, and another just in case there are more moves after the game.

I believe moving the implementation of this feature from the CSS or DISPLAY to the PGN engine is an overkill.

eikob commented 11 months ago

Another possibility would be to add the additional moves as a variation, perhaps with the last main line move doubled. This would make sense from a logical side, too, as those moves are just not part of the original game main line.