lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.08k stars 2.23k forks source link

Material balance and notation stale when move confirmation is pending #14082

Open eikob opened 10 months ago

eikob commented 10 months ago

Exact URL of where the bug happened

Playing a (corr) game with move confirmation on.

Steps to reproduce the bug

  1. Play a (corr) game with move confirmation on
  2. Make move, maybe capture a piece

What did you expect to happen?

I expect the notation to show and highlight the move, and the material balance to correspond to the position on the board.

What happened instead?

The notation and material balance was not updated and still matches the situation before the move. Only after the move everything gets updated.

Operating system

macos

Browser and version (or alternate access method)

Chrome

Additional information

The current situation is a bit confusing. Especially the material balance got me by surprise ("what, I am a piece down?") only to realize that my recapture is not reflected in the data yet.

I did not notice the missing move in the score sheet until writing this issue, but it should probably be addressed the same time. After all, it asks to "confirm the move" but highlights the previous mainline move in the notation.

lsap commented 10 months ago

Confirmed in Windows 10, Firefox 120.0