search

lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.08k stars 2.23k forks source link

Date format and plurals incorrect in team message counter #14382

Open TheForkPower opened 8 months ago

TheForkPower commented 8 months ago

Exact URL of where the bug happened

https://lichess.org/team/your-team-here/pm-all

Steps to reproduce the bug

Use up 6 team messages Wait a week until an hour before your team messages are gonna b refilled

What did you expect to happen?

good grammar

What happened instead?

bad grammar

Operating system

Macbook Air (catalina)

Browser and version (or alternate access method)

Chrome

Additional information

Screenshot 2024-01-05 at 08 20 02
TheForkPower commented 8 months ago

should be an easy fix

M-DinhHoangViet commented 8 months ago

image I don't know where the grammatical mistake is

M-DinhHoangViet commented 8 months ago

@TheForkPower Can you post a more grammatically correct text?

TheForkPower commented 8 months ago

There are basic errors in the English text displayed in the original screenshot that should be easy to spot @M-DinhHoangViet regardless of the rushed description I wrote around it.

Anyways, I can elaborate.

These issues only happen when:

  1. You have used all but 1 team messages for the week
  2. The weekly team messages are about to be refilled

So your screenshot above is clearly irrelevant.

Bold text is the counter. It displays ('1 messages left') which is an incorrect plural, basic English. It should read ('1 message left'). Also, when the team messages are about to be refilled, like on the time before tournament counter, it can read 'in x hours/minutes so you get these extraordinarily incoherent strings of text like in my original screenshot.

Hope you can understand now. #14386

M-DinhHoangViet commented 8 months ago

Because I'm Vietnamese, I'm not fluent in plurals in English. So, can you quote a text that you think is wrong and send back a text that you think is correct?

fitztrev commented 8 months ago

@TheForkPower It was not clear to me either what issue you were reporting. A diff would help or circle the relevant part of your screenshot.

-  1 messages remaining until in 32 minutes.
+  1 message remaining. Resets in 32 minutes.

@M-DinhHoangViet Thanks for working on this.

M-DinhHoangViet commented 8 months ago 
-  1 messages remaining until in 32 minutes.
+  1 message remaining. Resets in 32 minutes.

I'm wondering about this image image

TheForkPower commented 8 months ago

Yes you've got it down @M-DinhHoangViet nice patch

M-DinhHoangViet commented 8 months ago

So how do you plan to solve it @TheForkPower ?