Broadcasts: ordering problem

lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞

https://lichess.org

GNU Affero General Public License v3.0

15.29k stars 2.25k forks source link

Broadcasts: ordering problem #14739

Closed SergioGlorias closed 2 months ago

SergioGlorias commented 7 months ago

One of the known problems in broadcasts is if the organizer rearranges the position of the boards Whether unintentionally or by choice

Lila can understand that there is a change, but she doesn't know what to do

Since she doesn't know what to do, we get errors What will create a problem is that we are forced to restart the round But if it's not intentional, the organizer ends up correcting it and we have to start over again.

This is a complicated problem because it can cause some problems if not done well.

schlawg commented 7 months ago

Can at least a part of this be isolated to a minimum set of steps to reproduce an undesired behavior? Example:

Create a broadcast
Add a round
Upload n in-progress games
Go to XYZ and switch the order of games QRS
Result: ABC, when it should be DEF.

SergioGlorias commented 7 months ago

In this case, now I remember some questions

if there are 5 games in the broadcast (the number is an example)
- If the position is: 1 2 3 4 5 but is now 1 2 4 3 5, the system gives an error
- If you change the names of the pairing players (for example: the organizer remembered to use the same source for all rounds (and the mule (example) was not used to filter the round (that's another question #14334)) or remembered that it wasn't the player's right name): It will not generate an error but it can do strange things that need to be noticed by broadcasters to correct

In this case I only refer to multiboard

SergioGlorias commented 7 months ago

If the position is: 1 2 3 4 5 but is now 1 2 4 3 5, the system gives an error

The system found that 4 is 3

SergioGlorias commented 7 months ago

Note that there may also be an issue that in some broadcasts players are unnamed.

ornicar commented 3 months ago

Given that there are no unique identifiers for boards, that organizers can change the player names and the board orders, there is no fool-proof way to guess which board is which. Lila has several strategies to handle the most common aberrations. I'll try adding more.

SergioGlorias commented 3 months ago

It is known that it is not infallible, the point is that the tags are the same, only the order has changed (of course I don't mean tag round)

ornicar commented 3 months ago

Yes I agree there's something more to be done here.