search

lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.52k stars 2.26k forks source link

modernize ui/learn #15098

Closed schlawg closed 4 months ago

schlawg commented 6 months ago
  1. Get rid of mithril, seems like it's just boilerplate.
  2. Either get rid of chess.js dependency or convince this mythical ornicar person to put it in npm. some pnpm versions find github repo links in package.json offensive.
  3. Investigate compatibility with chessground 9.0.4 (learn module links to a really old version and i'd like to know why).
ornicar commented 6 months ago

it uses a chessground fork to display stars and maybe other garbage on the board. I don't think we should make the normal chessground any heavier just for ui/learn.

But a newer fork could be used. Heck, maybe current chessground can do it on its own, idk.

brollin commented 5 months ago

A refactoring task that when finished, the user will never know? That's my jam. It was fun to see what people did with the coordinate trainer after that was snabbdomified.

At least from what I've seen, it does seem like most if not all of the required chessground functionality exists in the latest chessground. Namely allowing custom SVGs should get us pretty far I would think (🤞).