lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
14.91k stars 2.22k forks source link

Analysis board should not show & link to unreviewed wikibooks pages #15340

Open ufshaikh opened 2 months ago

ufshaikh commented 2 months ago

Currently vandalism/whatever other inappropriate edits from anyone might be served through the sidebar on the left of the analysis page.

E.g., https://en.wikibooks.org/wiki/Chess_Opening_Theory/1._e4/1...c5/2._Nf3/2...Nc6/3._d4/3...cxd4/4._Nxd4/4...g6/5._c4 currently has some inappropriate text that, while in this case happens to be not vulgar or too bad, will presumably not pass review.

By contrast the latest stable version of the page https://en.wikibooks.org/w/index.php?title=Chess_Opening_Theory/1._e4/1...c5/2._Nf3/2...Nc6/3._d4/3...cxd4/4._Nxd4/4...g6/5._c4&stable=1 does not.

To reproduce go to the analysis board through the tools menu, input moves for the Maroczy Bind in the Accelerated Dragon (moves are in the above links), and look at the text on the left.

2024-05-20_22-05-1716263982

Siderite commented 2 months ago

This is a Wiki issue, not a Lichess issue. You can go to the page and request an edit or a removal.

ufshaikh commented 2 months ago

It is a lichess issue. Whether to crib from and link to the stable page or the most recent page on lichess's analysis board is very obviously a decision made by lichess. Again, the issue is not about this specific text on wikibooks.org (which has already been reverted) but that the current process allows arbitrary edits from anyone to be served up by lichess as soon as they're made, which clearly has the potential to be bad. The only downside afaict to linking the stable page instead is that productive edits take slightly longer to show up. (For myself I doubt wikibook's legitimate edits to opening theory pages are at this point particularly time sensitive to get out onto analysis boards everywhere.)