search

lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.79k stars 2.28k forks source link

Patron: Double Lifetime #15779

Open SergioGlorias opened 4 months ago

SergioGlorias commented 4 months ago

Exact URL of where the bug happened

https://lichess.org/patron/list

Steps to reproduce the bug

  1. Become a Lifetime Patron
  2. Go to https://lichess.org/patron/list
  3. Try purchasing a new Lifetime for your account

What did you expect to happen?

The button should be blocked as in https://lichess.org/patron (without monthly patron)

What happened instead?

Allows you to purchase the plan again

Operating system

Any

Browser and version (or alternate access method)

Any

Additional information

the page reacts as if the person were free

kraktus commented 4 months ago

I don't consider it a bug, people can donate again if they wish

SergioGlorias commented 4 months ago

@kraktus If you are a lifetime patron, you cannot purchase another lifetime on your account You can donate in other methods, but lifetime does not happen again

If you have a lifetime without a monthly donation, go to /patron and try to buy a lifetime for yourself It will be blocked, but the same does not happen in /patron/list

Siderite commented 4 months ago

I have an issue related to this, maybe take it into consideration. I've added a "donation" link to LiChess Tools where people can give wings to my user, so essentially giving some money to Lichess. However, a misguided good Samaritan gifted me lifetime wings. There should be a mechanism to allow further donations.

ornicar commented 4 months ago

I don't know what we should be doing about that.

Siderite commented 4 months ago

As I was telling Sergio, if the wings feature is a way to donate to Lichess, having a cap on it is silly. How about multiple wings? Larger wings? Fancier wings? I know Thibault hates gamification of things, but people WANT to give money as thanks.

NoseKnowsAll commented 4 months ago

@kraktus If you are a lifetime patron, you cannot purchase another lifetime on your account You can donate in other methods, but lifetime does not happen again

If you have a lifetime without a monthly donation, go to /patron and try to buy a lifetime for yourself It will be blocked, but the same does not happen in /patron/list

I am a lifetime patron. I no longer have the donate button anymore on my home page, but I can go to the patron URL itself as you linked. From there, I still can buy another lifetime donation. I don't see this as a problem - you are allowed to donate twice and get nothing from the second one.

SergioGlorias commented 4 months ago

@NoseKnowsAll My issue here is not to prohibit donating There is a one-time and monthly donation that can be used The question is whether at https://lichess.org/patron the lifetime button is blocked So https://lichess.org/patron/list should also be blocked

Note: in one-time or monthly you can customize the value and pay more than the lifetime

SergioGlorias commented 2 months ago

example more clean this case: Screen recording 2024-09-22 18.38.20.webm

https://github.com/lichess-org/lila/blob/master/app/controllers/Plan.scala#L53

Some Patron return indexFree