search

lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.09k stars 2.24k forks source link

Rating history chart error on perf page #16110

Open allanjoseph98 opened 3 hours ago

allanjoseph98 commented 3 hours ago

Exact URL of where the bug happened

https://lichess.org/@/thibault/perf/bullet

Steps to reproduce the bug

Open the link

What did you expect to happen?

Rating history for one perf

What happened instead?

Console error:

Uncaught (in promise) TypeError: e.findIndex is not a function ys chart.ratingHistory.76BBILZ5.js:formatted:4985 b common.PO2XX66P.js:1 async bullet:7 promise callback bullet:7 chart.ratingHistory.76BBILZ5.js:formatted:4985:8

Operating system

Windows 11

Browser and version (or alternate access method)

Firefox 130

Additional information

It seems that the array is being wrapped in a string instead of as a plain array

ornicar commented 2 hours ago

according to git bisect it was broken by https://github.com/lichess-org/lila/commit/4bb4676a30c3a5ccfce58768d0d7966827cf21f7

ornicar commented 2 hours ago

@schlawg wanna take a look?