search

lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.57k stars 2.28k forks source link

Remove broadcast source error sound #16246

Open loepare opened 6 days ago

loepare commented 6 days ago

When being contributor to a broadcast, a nasty error sound occurs when a source error happens. I thought for months that my headset was broken, because I couldn't match the sound to Lichess (I often have broadcasts open in the background). The personal story is not so important here, what I want to say is; I don't see the point of that sound, it doesn't really help much IMO.

allanjoseph98 commented 6 days ago

https://github.com/lichess-org/lila/blob/c664cd0980a1f738cbc44356d92a347d897e6236/ui/analyse/src/study/relay/relayCtrl.ts#L160-L162

Plays after 3 consecutive sync errors. Don't think the console warning is useful either.

SergioGlorias commented 5 days ago

The sound even has a reason: if the broadcaster has broadcast open, he will be alerted that there is an error.

It helps a lot to warn that the broadcaster has to act and not stay asleep

Although it currently does not warn of errors like it used to (missing or disordered chapters) which was more important

loepare commented 5 days ago

I understand the intention behind it, but I think most people wouldn't even understand that this sound is caused by the error of a lichess source.

SergioGlorias commented 5 days ago

Note: this error only happens to those who are contributing to the round and not a global sound

ornicar commented 4 days ago

So? Keep or remove?

SergioGlorias commented 2 days ago

For me, keep For admins the warnings seem useless since they can see the logs via IRC, but there are several people who do not have access and a warning is enough to solve the problem.

SergioGlorias commented 2 days ago

Plays after 3 consecutive sync errors. Don't think the console warning is useful either.

Previously, there was sound for any error, but it was limited because there were momentary errors