search

lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.52k stars 2.26k forks source link

boardeditor (ui/editor) does not update FEN #1872

Closed chiller2020 closed 7 years ago

chiller2020 commented 8 years ago

The boardeditor (ui/editor) does not update FEN when dragging a spare piece to the first available square starting top left.

Thats caused by chessground not firing an updated event in that case when the drag is initiated via https://github.com/ornicar/lila/blob/master/ui/editor/src/drag.js and passed to chessground and the piece is dropped to that first empty square thats used by https://github.com/ornicar/lila/blob/master/ui/editor/src/drag.js .

thomas-daniels commented 7 years ago

It works now. Probably this was fixed as a side-effect of the fix of a crazyhouse drop bug.

ornicar commented 7 years ago

Ha, I looked for that issue to close it, without success. Thanks.

chiller2020 commented 7 years ago

Is this issue solved also for the V3 version of chessground ? And where do i find the fix for the crazyhouse drop bug so i may copy it for my chessground V3 issue ?

ornicar commented 7 years ago

Here's the fix that can probably backported to v3 & v2: https://github.com/ornicar/chessground/commit/0d8cfabdca7c236a723d49dd1c24992bc78ba662

chiller2020 commented 7 years ago

Thanks a lot.