search

lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.62k stars 2.28k forks source link

Analysis en passant capture sound #4062

Closed ddugovic closed 6 years ago

ddugovic commented 6 years ago

During analysis the first time an en passant move is played, it sounds like a move (not like a capture). https://lichess.org/forum/lichess-feedback/no-sound-on-en-passant-captures#1

greg-finley commented 6 years ago

Can you give more repro steps? It sounds like a capture to me.

niklasf commented 6 years ago

@greg-finley-ck play the en passant capture here: https://lichess.org/analysis/standard/rnbqkb1r/pppp1ppp/5n2/3Pp3/8/8/PPP1PPPP/RNBQKBNR_w_KQkq_e6_0_3

for me the very first time it does not sound like a capture

greg-finley commented 6 years ago

This line affects those sounds, but I might be stuck after that:

https://github.com/ornicar/lila/blob/a64bc9f5534954ec5b899b8c9af02bb835bc358b/ui/analyse/src/ctrl.ts#L445

BrandonE commented 6 years ago

I experience this for all en passant captures on the above analysis board, not just the first one. Playing as an anonymous user on a mobile device in the web view.

ddugovic commented 6 years ago

I guess it should apply logic like https://github.com/ornicar/lila/blob/a0ccb32426db0dc191b55bfdd89386a06357c02b/ui/ceval/src/pv2san.ts#L136