search

lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.65k stars 2.28k forks source link

move String.Html into common.base #4502

Closed isaacl closed 6 years ago

isaacl commented 6 years ago

and probably create a case class instead of using twirl html

niklasf commented 6 years ago

twirl's Html does not get escaped when used in templates. i wonder if a custom case class can get the same behavior.

isaacl commented 6 years ago

not sure.

In any case, I think it's OK for RawHtml to return Strings now that it's in a separate file. so I'm going to close this, feel free to reopen if you want to work on it