Progressive Web App - Githubissues

lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞

https://lichess.org

GNU Affero General Public License v3.0

14.84k stars 2.2k forks source link

Progressive Web App #5492

Open emilmuller opened 4 years ago

emilmuller commented 4 years ago

If I could ever wish for something in the whole wide world, it would be that lichess conformed with the PWA requirements. It would be awesome to have lichess on my start menu :)

niklasf commented 4 years ago

[ ] Add to homescreen (manifest exists, but Chrome does not suggest installing until basic offline functionality exists)
[x] Push notifications (#3360)
[ ] Basic offline functionality (analysis, puzzles)
[ ] Advanced offline functionality (studies, correspondence)
[ ] Launch icon badging
[x] Keep screen on (#5260)
[ ] Web authentication (#4924)

neubland commented 4 years ago

Actually, Chrome needs the existence of a service worker with "functional fetch handler" for suggesting installation, not necessarily offline functionality like analysis and puzzle. It would be enough if all the basic service worker did was to serve a offline.html page that tells the user that they are not connected to the internet. More functionality could be added later on. Example service worker: https://serviceworke.rs/offline-fallback_service-worker_doc.html Depending on how long the road to offline support is gonna be this may be a good temporary solution.

One more point: could "Maskable Icon" be added? Android uses adaptive icons and PWAs are able to serve adaptive icons. This would enhance integration on Android if installed as PWA. More info on maskable icons: https://web.dev/maskable-icon/

niklasf commented 4 years ago

Regarding the fetch handler, simply adding one means that requests must now go through the service worker, adding some latency, so I am hesistant to do so without more tangible benefits. The MVP should have navigation preload and a sound update mechanism for the service worker.

[ ] Maskable icons (Manifest is here, if someone wants to make a PR: https://github.com/ornicar/lila/blob/1394817ff5676f90efe0e28db9aa9a01d48c1945/app/controllers/Main.scala#L150-L180)

ofek commented 2 years ago

Any update on this?

schlawg commented 1 year ago

Here are some thoughtful PWA suggestions from the_mindset I didn't want to get lost.

Adding this to the pile...