lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.5k stars 2.26k forks source link

Piece updates #5707

Closed ornicar closed 4 years ago

ornicar commented 4 years ago

Let's use this issue for the updates on all piece sets /cc @sadsnake1

ghost commented 4 years ago

tweaks for many sets

sets.zip

Also, thank you, hope you like dubrovny!

ornicar commented 4 years ago

I do. Have I already invited you to the lichess discord? https://discord.gg/dGVZjS We could have real-time chats there, and you'd meet more members of the community.

ghost commented 4 years ago

sets2.zip

ghost commented 4 years ago

staunty.zip

Arcovion commented 4 years ago

I personally much prefer the old knights in the staunty set

ornicar commented 4 years ago

I also miss the knight with a twisted ear. It was really unique and cute.

icp1994 commented 4 years ago

@sadsnake1 I think it might be better if you could change the outline color for the black Dubrovny pieces so that the black King and Queen would appear more distinct

2019-12-02 13 50 55 lichess org 6e35885310da

ghost commented 4 years ago

sets.zip -fixed the knight in staunty and outline and color in dubrovny

ghost commented 4 years ago

The german knight did not quite fit with the set, it had a good design but it is more beautiful in 3d, so I finally found the perfect design for the knights in the staunty set.

Capture

t+s+d.zip

cristian-5 commented 4 years ago

We forgot to update the outdated cursor icons that come up in the board editor. They're pixelated and old...

ornicar commented 4 years ago

No they're fine.

ghost commented 4 years ago

last tweaks

s+d.zip

ghost commented 4 years ago

New set - libra

Capture

libra.zip

ghost commented 4 years ago

s+g+c.zip

-added highlights to gioco -final knight for staunty. -final knight for cardinal.

ghost commented 4 years ago

s+g+c+m.zip -fixes + gradient for staunty

also, please dont add libra, it's very substandard

superuser-does commented 4 years ago

I think Libra's an excellent set, I can see only one major flaw which is the piece leg, which should be symmetrical. I recommend making it extend just slightly on either side. Here's a very quick mockup: image

The only other thing I'd look at is that the Bishop looks a bit too big compared to the other pieces. The Bishop will be next to the King and Queen in the starting position, so it's jarring to see that piece be so much more prominent in comparison. Admittedly there is no easy fix for this, but that's the only real issue

superuser-does commented 4 years ago

Gioco was my least favourite of your pieces but it's massive risen in my estimation with the latest update, and I think it's a first-class set now. I have to be honest though, the knight still bothers me, it looks like its neck has been dislocated! I'm also not sure if the sharp edges of the knights fit that well with the rest of the pieces, which are slightly more rounded.

Please consider revising the knight slightly. I think you should still keep it simple so without an eye, etc and with the same gradient/highlight style, it's just the basic shape of that one piece that needs changing.

aijcoa commented 4 years ago

Fresca is my favourite and I'd like to propose this set as the default peice set of lichess. Let's move on from cburnett once and for all.

ghost commented 4 years ago

s+g+c+m.zip

i fixed the libra set also.

I will look into revising the knight for the gioco set.

ghost commented 4 years ago

@superuser-does I think that the original (1st) knight is the best for the set. What knight do you think will do best?

Capture

aijcoa commented 4 years ago

5th is great @sadsnake1

JimiRecard commented 4 years ago

I think that the original (1st) knight is the best for the set. What knight do you think will do best?

3rd and 6th knight look the best among those, imo.

JimiRecard commented 4 years ago

Also, would you consider revising the staunty queen? That's the only piece preventing me from using the set, which is a shame since I really like the knights. The thing is I don't get the sense of danger from the queen that I get from other sets, probably because I'm used to pointy queens. The current staunty queen does not get my attention compared to the other pieces. It does not look "aggressive" enough, if that makes sense.

I get the same issue with the dubrovny queen. Also the dubrovny bishop looks a bit like a toilet unclogger. I think it could use a gap.

aijcoa commented 4 years ago

FYI you can edit comments @JimiRecard

JimiRecard commented 4 years ago

@f7n thanks! Didn't know that!

ghost commented 4 years ago

t+s.zip

-changed the gradient, enlarged the knight

@JimiRecard if you have any ideas on how to make the queen more agressive, let me know. I made staunty to look like the standard staunton chess set. Also dubrovny is a carcicature of dubrovnik set. So, if you have any ideas or sketches post them here and we will work it out.

icp1994 commented 4 years ago

@sadsnake1 I have one feedback about the dubrovny set. The rooks, especially their middle parts, looks really thinner compared to the other pieces.

JimiRecard commented 4 years ago

@sadsnake1, I have an idea, but I'm terrible at drawing. It should have the same base as the other pieces. From the base, there should be an even number of "spikes" coming out (either 4 or 6 works). Behind the spikes, the "dome" of the crown should be visible, with that characteristic ball at the center. I think the spikes should not end with balls, but pointy, like the ones in the staunton set do. I realize from that description that you can think of the current queen. The difference in my idea is that the dome would be much closer to the base, and the spikes would stretch much further, passing the dome. Also, the junction of the spikes would be much closer to the base. I'm picturing spikes like the ones in the maestro set. Let me know if you can visualize that. I can make a terrible sketch, if you want.

For the dubrovny sets I realize the bishop does not have a gap in the real life set as the staunton does, so I take back my previous suggestion.

Once again, thank you for your work. It's really hard to design 2D chess pieces, and you designed 8 sets that look great. I'm sure I'm not the only Lichess user that appreciate your work. Congrats!

ghost commented 4 years ago

dubrovny.zip -made dubrovny more like staunty

@JimiRecard please make me that terrible sketch, because i can't visualize it.

maybe this queen is more agressive than the original, still the original is best suited for the overall set

Capture

JimiRecard commented 4 years ago

@sadsnake1 I'll try to make the sketch. Any software you suggest? I do like that new queen, also.

ornicar commented 4 years ago

ghost commented 4 years ago

@ornicar sorry for the error

-added highlights to dubrovny (sleek set now) -changed the pawn of maestro d+m.zip

@JimiRecard I tried making a queen from your sketch but it does not look good and it does not look "staunton".

ghost commented 4 years ago

Remade libra into something more simple.

Capture

libra.zip

ghost commented 4 years ago

@ornicar can you please update lichess.dev with the all the new pieces and updates to check for errors and such?

cristian-5 commented 4 years ago

I made a new 8-bit set, I'll be happy to give it to you guys, here's everything:

8-Bit Chess Set

8-Bit.zip

ghost commented 4 years ago

-added effects to libra set Capture

libra.zip

superuser-does commented 4 years ago

Not sure about the new libra - it might be better to split it into two sets? This is a very different set to what you had before. On the other hand, I agree that the previous isn't a super strong set, and it hasn't been deployed to lichess.org yet.

As for the new version, I mostly like it aside from the king, who feels a bit squashed. Also, the gradient is a bit strong on the black pieces IMO, but overall an improvement.

ornicar commented 4 years ago

I think we should try to have fewer sets that are very different one from another. I'm concerned about overchoice issues

ornicar commented 4 years ago

The sets are deployed on https://lichess.dev

ghost commented 4 years ago

@ornicar Thank you! Also Thank you @superuser-does for your support. Here is the last update.

s+d.zip

ghost commented 4 years ago

@ornicar can you please redeploy the update sets?

ghost commented 4 years ago

So, this is how the sets should look now Capture

Ornicar, you don't have to be concerned about overchoice, because Staunty and Dubrovny should be similar, because they are sisters, they both come from the house of Staunton. Libra and Gioco are very different now, Gioco has a more wood feel and Libra is more metalic/jelly feel. One is more, let's say canonical and one is more free from regulations.

d+l.zip - (last update) this is my last set ornicar. I will not create anymore sets.

ghost commented 4 years ago

Also i would not post anymore updates or change anything, maybe just some sizes, but I think now that all sets look perfectly how they should when I had visioned them in the first place.

ghost commented 4 years ago

-fixed some size problems in libra and dubrovny -color in dubrovny d+l.zip

Capture

ghost commented 4 years ago

Right now, on lichess.org, the sets that must be updated to the last and final version are: -Maestro -Tatiana -Staunty -Dubrovny -Libra

I compiled here the final version for all of the above: m+t+s+d+l.zip

I've tripled check them!!!

Thank you all for your support and I hope you will enjoy these sets as much as I do!

superuser-does commented 4 years ago

Thanks for your great work.

Not sure how comfortable you are with this, but I believe that as you're super confident (I am!) with their final look, it might be a good time to run them through the validator.

Inkscape and other programs produce poor code a lot of the time, which forces the web browser into 'quirks mode' that can cause some slow-down. It's not a big deal but it can add up.

There's probably a more programmatic way of doing it compared to uploading to the W3C's service, but offline linters seem to be few and far between, and I'm not sure if I should trust them. Either way, it might still need us to edit dozens of files one by one...

This is an intimidating and pretty awful task if you haven't hand-edited SVG markup before, so let me know if you'd rather that I look into this instead @sadsnake1. Thanks.

ghost commented 4 years ago

Thank you for your support @superuser-does !

I do not yet understand what this validator does, but if you know that this will make the site run faster, please do it, because right now I don't have the necessary time nor the knowledge. I just created these sets in inkscape and that's all I know. So, please do what you think is best!

superuser-does commented 4 years ago

@sadsnake1 There's a bug report for the Maestro set on post 219 here, the pawns of the two sides are different sizes.

ghost commented 4 years ago

d+c+m.zip

-fix the mastero pawns -made dubrovny Q a bit smaller -fix king in cardinal

ghost commented 4 years ago

gioco.zip -changed the K, to the original idea of gioco, to be more in line with the set and that libra can be more different than gioco

Capture