lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.41k stars 2.25k forks source link

new sounds #594

Closed ornicar closed 9 years ago

ornicar commented 9 years ago

and anything else you can think of!

If you want to, we can have several sound themes.

Unihedro commented 9 years ago

New PM could be a louder / pitched up version of new message in chat.

Enigmahack commented 9 years ago

I'll set up multiple sound themes but I'll try and complete one at a time. Something else I was thinking was to have different sounds for first/second/third place in tournaments as well. Like...

3rd: Ta Da! (Imagine a horn sound or something) 2nd: Dum Ta Da! 1st: Dum du-de dum dum Ta Da! (Bigger more extravagant sounds for first but still short)

Also, what about different sound effects for different special awards? The bongcloud could have been a bubble sound right? Just some ideas anyway.

**edit - self note: Both in MP3 as well as OGG formats

ornicar commented 9 years ago

Excellent! I added entries for different tournament positions.

About the awards, I'm not sure how useful it would be. There aren't any awards available at the moment, but I'll let you know if/when there are.

Enigmahack commented 9 years ago

https://dl.dropboxusercontent.com/u/49099211/LiChess/LiChessPianoTheme.zip

This link is to a trial of sorts. I didn't have time to design sounds tonight, so I just recorded some sounds on my piano. Everything you hear here (Including captures and moves) are piano sounds so it's a true "Piano only" theme.

Anyway, we can use this as a test while I get a good workflow going for other sounds. I'll start with a standard set soon enough of actual sound effects, but thought this could be fun too.

ornicar commented 9 years ago

Wow, these sound great already :+1: Excellent recording and coverage of the different events :) Tournament wins are grand. This is very exciting! I can't wait to hear more!

Enigmahack commented 9 years ago

https://dl.dropboxusercontent.com/u/49099211/LiChess/NESTheme.zip

Sorry for the delay - I've been working on my band doing rehearsals and my keyboard wasn't in the studio. I've gotten a few things together, though I wanted to present the "NES (Nintendo Entertainment System) Theme" where all of the sounds are from the NES (or sounds very similar anyway)

I'll start getting to more "regular" themes soon as well, but thought this would be fun, if you wanted to start making these available as I make them perhaps?

Also wanted to ask: Is there a particular naming scheme you'd like to follow so we can just have "plug and play" into the website?

ornicar commented 9 years ago

Haha they're great :D I was waiting for this second theme before I get to the coding. Time for me to pull up my sleeves and put them sounds everywhere. I'll let you know when it's ready, and about the naming conventions.

ornicar commented 9 years ago

Just so we're on the same page, these sounds are gonna be licensed under MIT, which means everybody can use/modify them at will, even for commercial purpose. Like everything in lichess. You OK with this?

arex1337 commented 9 years ago

Great themes!

Enigmahack commented 9 years ago

Absolutely! That's good with me :-) On Jun 26, 2015 5:06 PM, "Thibault Duplessis" notifications@github.com wrote:

Just so we're on the same page, these sounds are gonna be licensed under MIT, which means everybody can use/modify them at will, even for commercial purpose. Like everything in lichess. You OK with this?

— Reply to this email directly or view it on GitHub https://github.com/ornicar/lila/issues/594#issuecomment-115862552.

ornicar commented 9 years ago

List of sound names: https://github.com/ornicar/lila/blob/master/public/javascripts/big.js#L1043

For now only 5 sounds supported, I'm implementing more.

Sound sets are organized in public/sound/{set}: https://github.com/ornicar/lila/tree/master/public/sound Each set directory must contain all sound files. Sounds that are not used yet are in public/sound/{set}/stock. Missing sounds are replaced with a symlink to another sound for now. Example: https://github.com/ornicar/lila/blob/master/public/sound/piano/Explosion.mp3

ornicar commented 9 years ago

From now on, if you would make PRs to directly add/modify sounds in public/sound/{set}, it would be coonvenient :)

ornicar commented 9 years ago

It's online.

Maybe some volume normalization is due. You can play any sound from your browser console (like $.sound.move()). I may also add a sound test page tomorrow.

ornicar commented 9 years ago

Here's a sound test page: http://en.lichess.org/assets/sound/test.html

It should help normalizing sound volumes!

ornicar commented 9 years ago

Well I'm done here, all sounds are applied (Will be online tonight). What remains to be done:

Enigmahack commented 9 years ago

That's awesome. I checked it out last night actually, and definitely need to normalize/compress the sounds so they're all a consistent volume. This is easy enough to do though.

I'll get to work on more themes and standard sounds as well. Any ideas of things you'd like to see for themes? I did the NES one more as a joke, but it actually turned out not too badly.

On Mon, Jun 29, 2015 at 7:52 AM, Thibault Duplessis < notifications@github.com> wrote:

Well I'm done here, all sounds are applied (Will be online tonight). What remains to be done:

— Reply to this email directly or view it on GitHub https://github.com/ornicar/lila/issues/594#issuecomment-116604664.

ghost commented 9 years ago

@Enigmahack For the NES sounds, I reckon you might want to replace some of the files with sounds from actual NES games.

Examples worth evaluating: the 1up sounds from Super Mario Bros 3, the power flower sound from Super Mario Bros 3, the little tune that plays at the very end of Super Mario Bros, the item get sound from The Legend of Zelda, all the sound effects from Duck Hunt (which gives room for easter eggs, especially the dog laughing when you fail)...

Enigmahack commented 9 years ago

I had considered it, but the reason I didn't was related to copyright concerns. I wouldn't want to get into anything like that, so instead did Nintendo - inspired sounds. That way it's original, no issues with copyright concerns and it still gets the idea across. On Jun 29, 2015 11:57 AM, "Evropi" notifications@github.com wrote:

@Enigmahack https://github.com/Enigmahack For the NES sounds, I reckon you might want to replace some of the files with sounds from actual NES games. Examples: the 1up sounds from Super Mario Bros 3, the power flower sound from Super Mario Bros 3, the little tune that plays at the very end of Super Mario Bros, the item get sound from The Legend of Zelda, all the sound effects from Duck Hunt (which gives room for easter eggs, especially the teasing dog)...

— Reply to this email directly or view it on GitHub https://github.com/ornicar/lila/issues/594#issuecomment-116717999.

ornicar commented 9 years ago

I wouldn't know which theme to add, but I do trust you entirely to find something great :)

ghost commented 9 years ago

@Enigmahack Fair enough... I just couldn't help but notice that you straight-up copied the explosion sound from The Legend of Zelda and the victory sound from Final Fantasy. :) Nintendo has been known for strict copyright enforcement, but not on older games (hell, Zelda Classic has been going strong for 10+ years). I wouldn't worry about it too much -- if you want to include an NES theme at all, I say make it as nostalgia-riddled as possible because no-one is going to stop you for legal reasons.

Enigmahack commented 9 years ago

@Evropi You want to know something funny? I've never actually played the old NES Zelda/FF games. Every sound I made was made on a Korg Kronos 2, so it was entirely coincidental (or oddly subconscious). It makes me want to go back and check what they did, and see how close the sounds actually were.

I see what you're saying though. The only reason I'd be worried about copyright is because while the games are old, they're also currently existing in the Wii U emulated versions of games that are being sold currently on the Nintendo market.

At the end of the day, are they REALLY going to go to a free, open sourced chess website and ask to take the sounds down? Probably not.

I'm actually not opposed, but if I were to do that I'd grab sounds from classic NES/SNES games, and give the theme a different name. Hrmm... Could be a thought anyway :)

On Mon, Jun 29, 2015 at 8:15 PM, Evropi notifications@github.com wrote:

@Enigmahack https://github.com/Enigmahack Fair enough... I just couldn't help but notice that you straight-up copied the explosion sound from The Legend of Zelda and the victory sound from Final Fantasy. :) Nintendo has been known for strict copyright enforcement, but not on older games (hell, Zelda Classic http://www.zeldaclassic.com/ has been going strong for 10+ years). I wouldn't worry about it too much -- if you want to include an NES theme at all, I say make it as nostalgia-riddled as possible because no-one is going to stop you for legal reasons.

— Reply to this email directly or view it on GitHub https://github.com/ornicar/lila/issues/594#issuecomment-116876867.

Enigmahack commented 9 years ago

Okay, I might need someone to walk me through replacing or introducing new sound sets. I didn't want to break anything haha.

I've got the new normalized sound set for the NES Sounds and the piano theme, and then I'll start working on some new themes today at some point. I just wanted to figure out how I might add things myself without breaking anything now that I know what the sounds need to be called.

https://dl.dropboxusercontent.com/u/49099211/LiChess/NES-Theme-Normalized.zip

This is the normalized NES theme.

https://dl.dropboxusercontent.com/u/49099211/LiChess/Piano-Normalized.zip

This is the normalized Piano theme. I've added Atomic and Berserk in there as well now too.

ornicar commented 9 years ago

Can you use Git?

Enigmahack commented 9 years ago

I might be able to, but I don't actually know... On Jul 1, 2015 11:21 AM, "Thibault Duplessis" notifications@github.com wrote:

Can you use Git?

— Reply to this email directly or view it on GitHub https://github.com/ornicar/lila/issues/594#issuecomment-117692063.

ornicar commented 9 years ago

Learning Git is quite an investment. If you want to: http://git-scm.com/

For now I'll update the sounds myself from your zips.

arex1337 commented 9 years ago

Sweet!

arex1337 commented 9 years ago

Theme ideas: Futuristic, new age, zen Modern war, military Medieval battle, vikings, Game of Thrones

Enigmahack commented 9 years ago

@arex1337 Great ideas! I'll take a look and see what I can come up with for some of those.

For now, I do have a new theme: SFX (They're just sound effects from things I've found lying around the studio, and some SFX libraries that are public domain)

https://dl.dropboxusercontent.com/u/49099211/LiChess/SFX-Theme.zip

ornicar commented 9 years ago

normalized piano & NES sounds are online.

Enigmahack commented 9 years ago

I just went through the GIT tutorial, and I was able to sync my local folders and such into the lila/public/sounds/ folder - Could someone double-check to make sure I did it right? If I did, then I'll be able to add new sounds generally whenever.

ornicar commented 9 years ago

https://help.github.com/articles/fork-a-repo/

ornicar commented 9 years ago

OK hmm, you're not supposed to push directly in lila repo. You should fork and submit pull requests.

Also could you please follow the naming conventions? See https://github.com/ornicar/lila/tree/master/public/sound/piano

Enigmahack commented 9 years ago

Understood - I'm setting that up now, I didn't 100% understand what I was doing initially but I think I've got a handle on it now.

I'll follow the piano naming convention from now on too.

Thanks man!

ornicar commented 9 years ago

Excellent. I'm renaming your SFX sounds, almost done.

ornicar commented 9 years ago

Also there's a sound that's missing from all (non-standard) sets, a pretty important one: LowTime. It rings when the chess clock approaches zero, as a reminder for the player they have to play fast.

Enigmahack commented 9 years ago

Yeah, I just noticed that as I was reviewing the naming convention. I'll add those to both the NES, SFX and Piano themes in my fork and submit a push request.

(I think that's how it works right?)

ornicar commented 9 years ago

that's how we roll!

Enigmahack commented 9 years ago

I'll figure out this development stuff sooner or later haha. But yeah, it makes sense entirely. I'll see what I can do then and submit when I'm ready.

ornicar commented 9 years ago

ask me on gchat if you're stuck.

ornicar commented 9 years ago

I have a theme suggestion: wood.

Unihedro commented 9 years ago

I have a theme suggestion: war.

Enigmahack commented 9 years ago

I like it, just working out creatively what certain things would sounds like lol.

Sent by Outlook for Android

On Wed, Jul 15, 2015 at 1:45 AM -0700, "Thibault Duplessis" notifications@github.com wrote:

I have a theme suggestion: wood.

— Reply to this email directly or view it on GitHub.

Enigmahack commented 9 years ago

Like this too, but I think we already have one planned called military or similar. Probably can combine them however.

Sent by Outlook for Android

On Wed, Jul 15, 2015 at 1:53 AM -0700, "Unihedron" notifications@github.com wrote:

I have a theme suggestion: war.

— Reply to this email directly or view it on GitHub.

ornicar commented 9 years ago

By the way, the futuristic sound theme is online.

ornicar commented 9 years ago

looks like we're done here. Feel free to make new sounds if you feel like it, they'll be welcome.

Enigmahack commented 9 years ago

Hey - Thanks for the message.

Yeah, things have gotten super busy lately, I'll try and see what I can contribute now that I have a process but other priorities have come up.

Thanks dave

On Thu, Sep 10, 2015 at 12:57 PM, Thibault Duplessis < notifications@github.com> wrote:

looks like we're done here. Feel free to make new sounds if you feel like it, they'll be welcome.

— Reply to this email directly or view it on GitHub https://github.com/ornicar/lila/issues/594#issuecomment-139290027.

isaacl commented 6 years ago

@Enigmahack Do you have uncompressed versions of your sounds that I could grab? We need to re-encode them for #3884