search

lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.62k stars 2.28k forks source link

Fractional rating part not used correctly in determining ranking #6122

Open thomas-daniels opened 4 years ago

thomas-daniels commented 4 years ago

https://lichess.org/@/ODMWND has 2328.21 rating points in Antichess and is ranked 2nd. https://lichess.org/@/AlekseyGuru has 2328.89 rating points and is ranked 3rd.

It doesn't look like a caching issue because Aleksey was ahead of ODMWND for hours, then ODMWND gained some points (didn't lose any) and got ahead of him.

greg-finley commented 4 years ago

Weird. I thought it would be sorted from the db here: https://github.com/ornicar/lila/blob/master/modules/user/src/main/RankingApi.scala#L66

I think maybe rating: Double here? https://github.com/ornicar/lila/blob/de6ba687cdd25ceb4e7a59274af5afc5e1702e30/modules/user/src/main/User.scala#L159

I think I'm too lazy to exhaustively test this though :)