search

lichess-org / lila

♞ lichess.org: the forever free, adless and open source chess server ♞
https://lichess.org
GNU Affero General Public License v3.0
15.65k stars 2.28k forks source link

Board resize handle is still visible on the analysis board, even with the setting disabled. #9712

Open benwh1 opened 3 years ago

benwh1 commented 3 years ago

On any analysis board (empty analysis board, after the end of a game, during a correspondence game, in a study), the board resize handle is always visible, even when the "display board resize handle" option is set to "never".

niklasf commented 3 years ago

The intent of even giving the option is avoiding accidental resizing in the heat of a game, so it doesn't apply for analysis. Not sure if we should change that, the description, or anything at all. Thoughts?

benediktwerner commented 3 years ago

Was changed in 3e77e6c6019e91a83cf857e1a6ab3943d88797e8.

I think all the options seem fine. The current behavior seems reasonably obvious and not sure if there's a nice and succinct way to improve the settings but if there is, it certainly wouldn't hurt either.

But there are certainly arguments to be made for how it was before.

benwh1 commented 3 years ago

The intent of even giving the option is avoiding accidental resizing in the heat of a game, so it doesn't apply for analysis. Not sure if we should change that, the description, or anything at all. Thoughts?

I've accidentally resized the board several times while doing analysis in correspondence games and studies and it's quite annoying. I have the board size set to what I want it to be, and I have no reason to randomly change it half way through some analysis.

My preference would be adding another option, e.g. "never during games", which would behave the same as the current "never" option, and have the "never" option hide the handle in games and analysis boards.