lichess-org / mobile

Lichess mobile app v2
GNU General Public License v3.0
1.36k stars 197 forks source link

feat: [Analysis Board] Added option to open Board Editor #1032

Closed sid0-0 closed 2 months ago

sid0-0 commented 2 months ago

PR implements: #992

Also includes minor cleanup

Screenshots: image image

sid0-0 commented 2 months ago

There are changes from 1 commit wherein I had to upgrade AGP version to make it work with flutter beta channel. I can remove the commit but the question is, aren't these changes required?

tom-anders commented 2 months ago

There are changes from 1 commit wherein I had to upgrade AGP version to make it work with flutter beta channel. I can remove the commit but the question is, aren't these changes required?

It's already fixed on the main branch, but your fork is a few commits behind.

One way to fix this:

git remote add upstream https://github.com/lichess-org/mobile.git
git pull upstream main --rebase
git push -f

You'll probably get a conflict with your first commit, just do git rebase --skip in that case

veloce commented 2 months ago

Thanks!