Increase move list height in tablet/landscape view

lichess-org / mobile

Lichess mobile app v2

GNU General Public License v3.0

1.35k stars 196 forks source link

Closed tom-anders closed 3 days ago

tom-anders commented 2 weeks ago

Partially fixes #585, the bottom bar is still at the very bottom, but we at least use the space on the right hand side more efficiently now.

Before:

Screenshot_1730458251

After:

Screenshot_1730458271

This also affects all other screens that use BoardTable, but I think it looks nice, for example puzzle streak:

Before:

Screenshot_1730458340

After:

Screenshot_1730458306

veloce commented 2 weeks ago

Looks better, definitely! Perhaps more vertical padding around the move list would help. Here the player widgets look squeezed to the edge.

tom-anders commented 2 weeks ago

Looks better, definitely! Perhaps more vertical padding around the move list would help. Here the player widgets look squeezed to the edge.

Agreed 👍 or maybe add spacing around the top and bottom player widget instead

tom-anders commented 1 week ago

Added kTabletBoardTableSidePadding around the top and bottom widget, I think this looks very nice:

Screenshot_1731143843

veloce commented 1 week ago

Can you also share a screen recording of a new game showing the move list @tom-anders ? Thanks.

I want to make sure how the move list look like when it is empty (or when it has too few moves to fill all the space).

tom-anders commented 6 days ago

Sure, here's a video of the start of the game, and another one later in the game where the move list starts scrolling

veloce commented 3 days ago

Perfect! Thank you!