search

lichess-org / mobile

Lichess mobile app v2
GNU General Public License v3.0
1.35k stars 196 forks source link

Added choice picker in settings and game settings sheet to switch the clock position to the left side #1136

Closed Jimima closed 1 day ago

Jimima commented 2 weeks ago

Related to issue https://github.com/lichess-org/mobile/issues/1098

New developer here, I have had a crack at this. If there are omissions or errors or anything I have done incorrectly please just let me know. I am happy to learn more 😄

Jimima commented 2 weeks ago

Made the changes discussed. I honestly stole a bit from the theme selection implementation so I hope the same approach makes sense in this context. Comments are very welcome of course!

tom-anders commented 1 week ago

Currently, when the clock is set to left, there's some space on the right of the player widget (see screenshot below).

I think you can fix this by adding mainAxisAlignment: clockPosition == ClockPosition.right ? MainAxisAlignment.start : MainAxisAlignment.end to the two Row widgets inside the playeWidget

Screenshot_1731145252

Jimima commented 1 week ago

@tom-anders I added the snippet to the Row that I think needs it, I am not sure if the other one does. This gives the following layout:

This looks like what you were suggesting but let me know if it isn't 🙂

tom-anders commented 1 week ago

Yeah looks good! But I think you also need it to the Row that displays the material difference below the user name (see my original screenshot, you can capture some pieces to check this)

Jimima commented 1 week ago

Yes I see, makes sense I should have made some captures! Now added.

Jimima commented 1 day ago

😁 thanks!