468 show captured pieces instead of material imbalance

[Jimima]

Had a go at this, draft at this stage as there is a bit to do but wanted feedback on the overall idea, if possible

Relates https://github.com/lichess-org/mobile/issues/468

[veloce]

UI looks fine!

[Jimima]

I added a secondary option to the settings for this. I wonder if this is the best approach, it was simple to add it this way but maybe a single choice with 3 options would be better

Was also a bit unclear on why the theme preference implementation did something custom for the choice picker on ios, this seems to work but can take the other approach if there is a reason to do so

[ijm8710]

I think it makes more sense to have one setting with 3 options. Rather than 2 separate toggle due to the fact that the settings screen keeps getting more options and to limit it best we can.

Obv Veloce/toms opinion will carry more weight but I think it's best to keep that contained best they can

[Jimima]

Alternate option

[Jimima]

In-game option

https://github.com/user-attachments/assets/bf1684f8-4640-40fc-9575-d8cc518bbe88

[Jimima]

Would appreciate a review @veloce @tom-anders

[veloce]

It is better with a single setting yes. Thanks!

[Jimima]

@tom-anders I pushed up a bunch of changes, would appreciate you taking another look when you have the time 🙂

[tom-anders]

very nice, no more comments from me :)

[Jimima]

Oh should have said, I still don't really know the best label to use for the setting. I just changed it to simply "Material" just now but I've changed it a few times and still can't decide what is best. Happy to be told here!

[Jimima]

very nice, no more comments from me :)

Thanks, will take a look at the l10n stuff tomorrow

[Jimima]

@veloce @tom-anders I think I've gone as far as I can with this. Would appreciate any further feedback you have for me 🙂