Missing the alert sound when low on time.

lichess-org / mobile

Lichess mobile app v2

GNU General Public License v3.0

1.35k stars 196 forks source link

Missing the alert sound when low on time. #1164

Open p2pchess opened 3 days ago

p2pchess commented 3 days ago

Title says all

tom-anders commented 2 days ago

There's a setting to turn this on/off and it's synced with the Web UI - Can you double check that you have it enabled in your account settings?

p2pchess commented 2 days ago

Ok i found the problem, the low on time alert sound option only works when you're logged in the app, there's no way to turn sound alert when playing anonymous... Maybe moving the option to parameters > sound would make more sense

veloce commented 2 days ago

Well I don't think we're gonna change the way the settings work. But instead of having no sound when anonymous we can change it to always have sound. That way anon players will have the sound.

veloce commented 2 days ago

https://github.com/lichess-org/mobile/blob/4c554728d378321999e6ba915e6dc2d87287430a/lib/src/model/account/account_preferences.dart#L43-L46

^ It should work already.