search

lichess-org / mobile

Lichess mobile app v2
GNU General Public License v3.0
1.35k stars 195 forks source link

Add an option to show captured pieces instead of material imbalance #468

Open veloce opened 10 months ago

VaibhavKukreti-Kathud commented 9 months ago

Can I work on this issue?

veloce commented 9 months ago

Yes you can open a PR when you're ready.

arjun1194 commented 8 months ago

Hey @VaibhavKukreti-Kathud are you working on this ? if not i would like to pick this up :)

arjun1194 commented 8 months ago

what is the process of developing such features ? is there a PRD or a Proposal ?

HaonRekcef commented 8 months ago

No its simple, just fork the project, code your features, improvements, or bug fixes, and then create a pull request. The maintainer will then take a look at it, provide feedback, and approve it. However, note that the maintainer is currently on vacation, so it might take some time for the PR to be merged.

saurabhffs commented 6 months ago

@veloce I am working on this issue

sandeep-adireddi commented 6 months ago

Hey @veloce , Where is the best place to add a toggle option for showing or hiding this enhancement?.

veloce commented 6 months ago

Well I'm not sure, because there is a conflict with the "Material imbalance" option, which is already a toggle. We can't have both true at the same time.

sandeep-adireddi commented 6 months ago

Yeah, I asked this because i noticed this conflict. One option i found is similar to current app . Screenshot_20240513-211449