search

lichess-org / mobile

Lichess mobile app v2
GNU General Public License v3.0
1.1k stars 151 forks source link

Can no longer play anonymous games #687

Closed casbarof closed 1 month ago

casbarof commented 1 month ago

What is the problem?

As of 0.8.9, it’s no longer possible to play anonymous games. As the website still supports anonymous games, I assume this is a bug.

Steps to reproduce the bug

Open the app. Cannot play a game without logging in.

What did you expect to happen?

Can play anonymous games.

What happened instead?

Can’t play anonymous games.

Device Info

iPad Pro M2

Operating System Version

iPadOS 17.5

Additional information

No response

veloce commented 1 month ago

Can you explain why is it not possible anymore? Do you see an error or something?

ijm8710 commented 1 month ago

I think they're not aware that you can click the plus icon in top right

casbarof commented 1 month ago

The UI has changed. “Home” only has two links: “Sign in” and “About lichess”. The controls to start a game only appear once logged in.

ijm8710 commented 1 month ago

Top right there is a plus sign

casbarof commented 1 month ago

@ijm8710 There is no plus sign on my screen. Top right there is a players icon, but it doesn’t solve the problem at hand.

ijm8710 commented 1 month ago

@ijm8710 There is no plus sign on my screen.

Would help to share picture of your home then

casbarof commented 1 month ago

@ijm8710 Are you aware that this repo is for the new beta app, and that we’re talking about 0.8.9 specifically?

ijm8710 commented 1 month ago

@ijm8710 Are you aware that this repo is for the new beta app, and that we’re talking about 0.8.9 specifically?

Yes I'm aware. But you keep not sharing the picture of the home screen. If Veloce needs to debug why the plus sign is not appearing I'm sure he can look into it but frankly I'm still slightly skeptical you don't have it

casbarof commented 1 month ago

Only you asked for a screenshot, and you don’t seem to be a maintainer. I don’t need a plus sign to start a game after signing in. Why would I need a plus sign when I’m not signed in? Doesn’t make sense.

casbarof commented 1 month ago

IMG_0069

ijm8710 commented 1 month ago

Only you asked for a screenshot, and you don’t seem to be a maintainer. I don’t need a plus sign to start a game after signing in. Why would I need a plus sign when I’m not signed in? Doesn’t make sense.

Veloce asked if you had any error messages which you didn't provide any. So first instinct was that maybe you didn't realize that where the new mechanism for the create game is. And actually, you do need the plus sign to start a game now when logged in. Even more relevant, when logged out, there SHOULD be a plus sign to start a game then as well, so that is why I asked if you had it. I fully state that you are correct and it does indeed look bugged and my skepticism was not applicable here, but almost any way to debug this begins with confirming that the plus sign was indeed missing.

@Veloce probably worth a look maybe something to do with iPads or something?

casbarof commented 1 month ago

And actually, you do need the plus sign to start a game now when logged in.

Absolutely not. Once I’m logged in, there’s a huge “Play” button, and still no plus sign.

ijm8710 commented 1 month ago

And actually, you do need the plus sign to start a game now when logged in.

Absolutely not. Once I’m logged in, there’s a huge “Play” button, and still no plus sign.

Unless Veloce designed a diff design for tablets which I doubt, what you're seeing i don't think is expected

This is what it should look like for when you are logged in. Note the plus icon in the top right. That is the only mechanism to start a new game regardless of if you're logged in or not image

IMO there may be value to share what your homefeed looks like when logged in too because as far as I understand this huge play button is NOT normal behavior but it's up to you if you want to share that too.

veloce commented 1 month ago

Yes there is a problem on tablet, will fix it. Thanks for the feedback.

iamnabink commented 1 month ago

Hi @veloce,

I just reproduced this issue on the iPad Pro 6th generation. It looks like the plus button is not displaying on the iPad mainly because of this check:

if (isHandset)
    ...[
        const SizedBox(width: 6.0),
        AppBarIconButton()
    ]

The visibility is controlled by isHandset(). I want to clarify whether this is an intended handset check. If we remove that condition, the button will be visible on any device, which should resolve the issue.

I'll go ahead and make a PR. If that's fine with you, please merge it.