lichess-org / mobile

Lichess mobile app v2
GNU General Public License v3.0
1.1k stars 150 forks source link

Move Notation preference setting not followed in new app #759

Open LukeyPmoney opened 2 weeks ago

LukeyPmoney commented 2 weeks ago

What is the problem?

In the new app, the list of moves is always in letter notation when playing a game, but the analysis board (both the separate tool or within a game) always shows moves in figurine notation. Also, this preference setting can only be updated on the website, not in the app.

Steps to reproduce the bug

On the website, click/tap profile icon -> preferences -> display. Change the Move Notation setting to the opposite of what it was and save. Next, start a game in the lichess app and make a non-pawn move. Click analysis icon or switch to analysis board tool and make a non-pawn move.

What did you expect to happen?

Both in an active game and on the analysis board, the move notation preference setting should be respected. Also, this preference should be editable within the app instead of only on website.

What happened instead?

In-game in the new lichess app: game moves notation is in letter form regardless of move notation setting. Switch to analysis board, either the separate tool or within a game: game moves and moves within analysis lines are always in figurine notation, regardless of move notation preference setting.

Device Info

Samsung Galaxy S7

Operating System Version

Android 8.0.0

Additional information

No response

eliogilvy commented 1 week ago

@veloce which api call handles this? I'm looking at api/account/preferences and not seeing anything... I see it in Scala file but am not seeing the field when talking to the api/account/preferences.

awan1 commented 1 week ago

Verified on Android 14, Pixel 8