search

lichess-org / mobile

Lichess mobile app v2
GNU General Public License v3.0
1.22k stars 174 forks source link

only show next correct move when viewing puzzle solution #774

Closed Mauritz8 closed 2 months ago

Mauritz8 commented 3 months ago

close #761 This alters the "show solution button" to only show the next move in the solution, which is in line with both the website and the old app.

Mauritz8 commented 2 months ago

There is already an example of blinking button in game screen when a draw offer is received.

For me the draw offer button is just colored differently, it doesn't blink or anything like that. Is there another example of a blinking button? image

veloce commented 2 months ago

It doesn't blink? My bad then :)

Any visual indication would be good actually, blinking is not mandatory. Perhaps a simple background color inversion for a duration of 3s would be the best?

veloce commented 2 months ago

If you have the time to post a screen recording showing the feature and button visual indicator in action that would be great. Thanks!

Mauritz8 commented 2 months ago

No problem. I tried both blinking and color inversion, and I think blinking works a lot better. And I set the duration to 5 seconds instead of 3 because it felt a bit too short. Screencast from 2024-07-05 12:20:21.webm

Mauritz8 commented 2 months ago

I addressed your comments. I'm a bit uncertain about the test, it might not be done in the most idiomatic way.

veloce commented 2 months ago

Thanks!