search

lichess-org / mobile

Lichess mobile app v2
GNU General Public License v3.0
1.17k stars 164 forks source link

Automatically turn the chessboard around to your position when you're analyzing the chessboard #837

Open olivertzeng opened 1 month ago

olivertzeng commented 1 month ago

iOS 16.5 iPhone 14 Lichess Beta 0.8.18!imageimage

BAW2501 commented 1 month ago

Could you provide some clarification? It seems like you are importing a PGN and want it to rotate based on the player's name from the PGN. Is that correct? Also, please outline the steps to reproduce this problem.

olivertzeng commented 1 month ago

Could you provide some clarification? It seems like you are importing a PGN and want it to rotate based on the player's name from the PGN. Is that correct? Also, please outline the steps to reproduce this problem.

sorry for not providing that info. steps to reproduce: set if your username is foo and you were black, and another username called bar who played white, and you imported that game's PGN into Lichess it'll always show the white pieces on "your side" instead of what you were playing using [Black "foo"] what i expect: automatically detect your username and turn the board accordingly

Thanks @BAW2501 for responding! edit: stupid me accidentally turned around in the chess.com app will change that edit 2: omg stoopid me chess.com doesn't do that

ijm8710 commented 1 month ago

This is a good point. I also agree it would be helpful for imports to auto-adjust analysis based on what color you are playing if it is defined.

BAW2501 commented 1 month ago

not sure if this would be the desired behavior of the PGN importer as there is no guarantee that user foo in the PGN is foo from Lichess, I'll wait on the input of the main dev before I try my hand at it.

olivertzeng commented 1 month ago

not sure if this would be the desired behavior of the PGN importer as there is no guarantee that user foo in the PGN is foo from Lichess, I'll wait on the input of the main dev before I try my hand at it.

Well the example game I've imported Lichess was played in Lichess as well.

Mauritz8 commented 1 month ago

Well the example game I've imported Lichess was played in Lichess as well.

I'm a bit confused, are you importing lichess games into lichess? Are they not already in lichess then?

olivertzeng commented 1 month ago

Well the example game I've imported Lichess was played in Lichess as well.

I'm a bit confused, are you importing lichess games into lichess? Are they not already in lichess then?

Yes It was this game image But with less detailed suggestions compared to imported games.(something like (blunder xx was the best move)) image So sometimes I import game from exported Lichess games into lichess

Sorry for the confusion

Mauritz8 commented 1 month ago

Interesting workaround. So, what you really want is the comments? If that's the case I think we should address that, rather than adding features for the workaround.

I also wonder, how do you even open imported games in the app?

olivertzeng commented 1 month ago

No it's kinda like a separate issue though

And below this is how I import a game https://github.com/user-attachments/assets/e922c1f0-0004-4522-8127-1506b97b6ff4

olivertzeng commented 1 month ago

I also wonder, how do you even open imported games in the app?

It's not directly imported though it's exported then imported

Mauritz8 commented 1 month ago

No it's kinda like a separate issue though

No? So, why don't you just view the game from your profile then?

olivertzeng commented 1 month ago

No it's kinda like a separate issue though

No? So, why don't you just view the game from your profile then?

It’s an issue I would like to submit later for now but it’s still an issue that makes me export and then import the game in lichess after some games

veloce commented 1 month ago

So the whole thing is about seeing the all variations in an analysed game?

We can add an action to toggle the display of all variations at once (currently it's only possible with a context action for each variation, not the most convenient).

Also I don't like to add too much settings, but we could have another analysis settings to decide should be shown from the start or not.

olivertzeng commented 1 month ago

@veloce commented on Jul 16, 2024, 7:29 AM GMT+8:

So the whole thing is about seeing the all variations in an analysed game?

We can add an action to toggle the display of all variations at once (currently it's only possible with a context action for each variation, not the most convenient).

Also I don't like to add too much settings, but we could have another analysis settings to decide should be shown from the start or not.

no

i meant automatically facing black pieces to the player if the player's username matches the Lichess's username

veloce commented 1 month ago

The import PGN feature is not really meant to import lichess games in the first place...

olivertzeng commented 1 month ago

The import PGN feature is not really meant to import lichess games in the first place...

It's because that imported games have more info than just viewing from the profile. Please view all of the earlier comments in this thread

olivertzeng commented 1 month ago

Well the example game I've imported Lichess was played in Lichess as well.

I'm a bit confused, are you importing lichess games into lichess? Are they not already in lichess then?

Yes It was this game image But with less detailed suggestions compared to imported games.(something like (blunder xx was the best move)) image So sometimes I import game from exported Lichess games into lichess

Sorry for the confusion

This comment is what I would like to refer to. @veloce the games that are viewed directly from my Lichess profile doesn't have this issue(not rotating if player is black) though but because of this I import games from lichess to lichess

veloce commented 1 month ago

Have you read my comment: https://github.com/lichess-org/mobile/issues/837#issuecomment-2229614753 ?

You want to see the comments in italics and the variations (between parenthesis), I got it.

olivertzeng commented 1 month ago

Have you read my comment: https://github.com/lichess-org/mobile/issues/837#issuecomment-2229614753 ?

You want to see the comments in italics and the variations (between parenthesis), I got it.

Sorry for being mean And I actually like that idea But it's for a separate issue though